Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Tabular regression task and example #892

Merged
merged 19 commits into from
Nov 5, 2021
Merged

Tabular regression task and example #892

merged 19 commits into from
Nov 5, 2021
+242 −11

Conversation

Borda
Copy link
Member

@Borda Borda commented Oct 27, 2021 •
edited by ethanwharris
Loading

What does this PR do?

Fixes #905

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added the task flash Task label Oct 27, 2021
@Borda Borda requested a review from ethanwharris October 27, 2021 00:02
@codecov
Copy link

codecov bot commented Oct 27, 2021 •
edited
Loading

Codecov Report

Merging #892 (c58ef25) into master (d0adc61) will decrease coverage by 0.14%.
The diff coverage is 60.93%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #892      +/-   ##
==========================================
- Coverage   88.47%   88.33%   -0.15%     
==========================================
  Files         239      241       +2     
  Lines       12961    13017      +56     
==========================================
+ Hits        11467    11498      +31     
- Misses       1494     1519      +25
Flag Coverage Δ
unittests 88.33% <60.93%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/tabular/regression/model.py 51.35% <51.35%> (ø)
flash/core/model.py 88.05% <66.66%> (-0.15%) ⬇️
flash/core/regression.py 66.66% <66.66%> (ø)
flash/core/classification.py 94.15% <100.00%> (+0.03%) ⬆️
flash/tabular/__init__.py 100.00% <100.00%> (ø)
flash/tabular/classification/model.py 92.50% <100.00%> (-0.53%) ⬇️
flash/tabular/regression/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0adc61...c58ef25. Read the comment docs.

@Borda Borda marked this pull request as ready for review November 3, 2021 22:59
ethanwharris
ethanwharris approved these changes Nov 4, 2021
View reviewed changes
Copy link
Collaborator

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, example looks great 😃 Mind adding some docs / tests? (can be in a follow-up 😃)

flash/tabular/regression/model.py Show resolved Hide resolved
@Borda Borda requested a review from edenlightning as a code owner November 4, 2021 12:34
Borda
Borda commented Nov 4, 2021
View reviewed changes
flash/core/regression.py Outdated Show resolved Hide resolved
@ethanwharris ethanwharris changed the title tab regression Tabular regression task and example Nov 5, 2021
@ethanwharris ethanwharris mentioned this pull request Nov 5, 2021
Closed
@ethanwharris ethanwharris merged commit ba38014 into master Nov 5, 2021
@ethanwharris ethanwharris deleted the task/tab-regress branch November 5, 2021 13:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ethanwharris ethanwharris ethanwharris approved these changes

@ananyahjha93 ananyahjha93 ananyahjha93 approved these changes

@carmocca carmocca Awaiting requested review from carmocca

@justusschock justusschock Awaiting requested review from justusschock

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

@tchaton tchaton Awaiting requested review from tchaton

@edenlightning edenlightning Awaiting requested review from edenlightning

Assignees
No one assigned
Labels
task flash Task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Regression metrics raise error in semanticsegmentation task
3 participants
@Borda @ananyahjha93 @ethanwharris